CS 1.0: SD-2945: Add intermediateCalls to Legs#622
Merged
Conversation
Review Summary by QodoAdd IntermediateCall schema and property to Leg
WalkthroughsDescription• Add new IntermediateCall schema object for modeling intermediate stops • Add intermediateCalls array property to Leg schema • Enable grouping of non-transhipment calls within single leg • Support collapsible UI representation of intermediate stops Diagramflowchart LR
Leg["Leg"] -->|contains| IntermediateCall["IntermediateCall"]
IntermediateCall -->|has| Location["Location"]
IntermediateCall -->|has| TransportCallRef["transportCallReference"]
IntermediateCall -->|has| FacilityType["facilityTypeCode"]
IntermediateCall -->|has| ArrivalDT["arrivalDateTime"]
IntermediateCall -->|has| DepartureDT["departureDateTime"]
File Changes1. cs/v1/CS_v1.0.3.yaml
|
Code Review by Qodo
|
Comment on lines
+1671
to
+1676
| transportCallReference: | ||
| type: string | ||
| example: SR11111X-9321483-2107W-NLAMS-ACT-1-1 | ||
| maxLength: 100 | ||
| description: | | ||
| The unique reference for the arrival transport call. It's the vessel operator's responsibility to provide the Transport Call Reference, other parties are obliged to pick it up and use it. It can take the form of Port Call References as defined in OVS Definitions Document, or alternatively a reference as defined by the vessel operator. |
There was a problem hiding this comment.
1. Wrong transportcallreference description 🐞 Bug ≡ Correctness
IntermediateCall.transportCallReference is described as “the unique reference for the arrival transport call”, which is incorrect for an intermediate call and conflicts with the spec’s generic TransportCall.transportCallReference wording; this can lead implementers to populate/interpret the wrong reference.
Agent Prompt
### Issue description
`IntermediateCall.transportCallReference` currently says it is the unique reference for the **arrival** transport call, which is misleading for an intermediate call and inconsistent with the spec’s generic `TransportCall.transportCallReference` definition.
### Issue Context
Intermediate calls are explicitly defined as calls **between** the leg `departure` and `arrival`, so the field description should be neutral (transport call at this intermediate location) rather than arrival-specific.
### Fix Focus Areas
- cs/v1/CS_v1.0.3.yaml[1671-1676]
### Suggested change
Update the description to align with `TransportCall.transportCallReference`, e.g.:
- “The unique reference for a transport call …”
or
- “The unique reference for the transport call at this intermediate location …”
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SD-2945: Add an intermediateCalls object